[skip-changelog] Migrate tests from test_main.py to main_test.go
#1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
|
|
Codecov Report
@@ Coverage Diff @@
## master #1836 +/- ##
==========================================
- Coverage 36.34% 36.28% -0.07%
==========================================
Files 232 232
Lines 19496 19496
==========================================
- Hits 7086 7074 -12
- Misses 11583 11592 +9
- Partials 827 830 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cmaglie
requested changes
Aug 12, 2022
MatteoPologruto
force-pushed
the
test-to-go
branch
from
f41c63d to
d81f8f1
Compare
|
Thanks for the suggestion @cmaglie! Committed the changes and cleaned the commit history. |
umbynos
changed the title
test_main.py to main_test.go
umbynos
reviewed
Aug 12, 2022
umbynos
reviewed
Aug 12, 2022
MatteoPologruto
force-pushed
the
test-to-go
branch
from
d81f8f1 to
8a86752
Compare
per1234
added
topic: infrastructure
cmaglie
pushed a commit
to cmaglie/arduino-cli
that referenced
this pull request
Aug 22, 2022
…rduino#1836) * Migrated TestHelp from test_main.py to main_test.go * Migrated TestVersion from test_main.py to main_test.go * Migrated TestInventoryCreation from test_main.py to main_test.go * Migrated TestLogOptions to main_test.go and deleted test_main.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_main.pyhave been rewritten inmain_test.go, without changing their original purpose.The tests are the following:
I had to introduce a way to skip blank lines while checking the content of the log file written with the command
version --log-format json --log-file path/log.jsonin TestLogOptions. It seems that VSCode does not handle well a stream of JSONs and expects the end of the file to be sooner than the actual file's end, leaving a blank line in place of the last line of the file as a result, potentially compromising the whole test.Does this PR introduce a breaking change, and is titled accordingly?
No